Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geo 821/1174/1175 - e2e and change company name to employer name throughout admin portal #806

Conversation

goemen
Copy link
Contributor

@goemen goemen commented Oct 9, 2024

Description

  • User management end-to-end tests
  • Dashboard end-to-end tests
  • Change company name to employer name throughout admin portal

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@goemen goemen requested a review from sukanya-rath as a code owner October 9, 2024 22:04
@goemen goemen force-pushed the fix/GEO-1175-change-company-name-to-employer-name-throughout-admin-portal branch from d55be52 to ac3f5b3 Compare October 9, 2024 22:10
@goemen goemen force-pushed the fix/GEO-1175-change-company-name-to-employer-name-throughout-admin-portal branch from 0f450f4 to e8220b8 Compare October 10, 2024 16:20
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 10, 2024

@sukanya-rath sukanya-rath merged commit ece9604 into main Oct 10, 2024
32 checks passed
@sukanya-rath sukanya-rath deleted the fix/GEO-1175-change-company-name-to-employer-name-throughout-admin-portal branch October 10, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants